-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update specialisms #16
Conversation
68 => 'Verpl. spec. chronische zorg bij som. aandoeningen', | ||
69 => 'Verpl. spec. geestelijke gezondheidszorg', | ||
70 => 'Jeugdgezondheidszorg (Profiel KNMG Jeugdarts)', | ||
71 => 'Spoedeisendehulp (Profiel SEH Arts KNMG)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this to Spoedeisendehulp (Profiel SEH Arts KNMG)'
with one space
40 => 'Radiotherapie (radiotherapeut)', | ||
41 => 'Reumatologie (reumatoloog)', | ||
42 => 'Revalidatiegeneeskunde (revalidatiearts)', | ||
43 => 'Maatschappij en gezondheid (beëindigd per 01-01-2007)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this to Maatschappij en gezondheid
with one space and without (beëindigd per 01-01-2007). The SOAP response of http://webservices.cibg.nl/Ribiz/OpenbaarV4.asmx?op=GetRibizReferenceData returns it that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. The changes look great. I request just two minor changes. See my comments. Would you like to update the PR?
70 => 'Jeugdgezondheidszorg (Profiel KNMG Jeugdarts)', | ||
71 => 'Spoedeisendehulp (Profiel SEH Arts KNMG)', | ||
74 => 'Sportgeneeskunde', | ||
75 => 'Openbaar apotheker', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this one to Openbare Farmacie
. The SOAP response of http://webservices.cibg.nl/Ribiz/OpenbaarV4.asmx?op=GetRibizReferenceData returns it that way.
I checked the SOAP response of http://webservices.cibg.nl/Ribiz/OpenbaarV4.asmx?op=GetRibizReferenceData and found a small difference. Can you update |
There we go! 👍 |
@kingkorf Thank you very much 👍 |
Hi Erik, can you do a patch release (2.0.1?) so I can update my composer.json? |
@kingkorf Yes. The 2.0.1 release is added. |
Thanks! |
See https://www.bigregister.nl/doc/pdf/BIG%20register%20services%202.0_43640.pdf