Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specialisms #16

Merged
merged 4 commits into from
Dec 1, 2016
Merged

Update specialisms #16

merged 4 commits into from
Dec 1, 2016

Conversation

kingkorf
Copy link
Contributor

@kingkorf kingkorf commented Nov 2, 2016

@kingkorf kingkorf closed this Nov 2, 2016
@kingkorf kingkorf reopened this Nov 2, 2016
68 => 'Verpl. spec. chronische zorg bij som. aandoeningen',
69 => 'Verpl. spec. geestelijke gezondheidszorg',
70 => 'Jeugdgezondheidszorg (Profiel KNMG Jeugdarts)',
71 => 'Spoedeisendehulp (Profiel SEH Arts KNMG)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to Spoedeisendehulp (Profiel SEH Arts KNMG)' with one space

40 => 'Radiotherapie (radiotherapeut)',
41 => 'Reumatologie (reumatoloog)',
42 => 'Revalidatiegeneeskunde (revalidatiearts)',
43 => 'Maatschappij en gezondheid (beëindigd per 01-01-2007)',
Copy link
Contributor

@eriwin eriwin Nov 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to Maatschappij en gezondheid with one space and without (beëindigd per 01-01-2007). The SOAP response of http://webservices.cibg.nl/Ribiz/OpenbaarV4.asmx?op=GetRibizReferenceData returns it that way.

Copy link
Contributor

@eriwin eriwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. The changes look great. I request just two minor changes. See my comments. Would you like to update the PR?

70 => 'Jeugdgezondheidszorg (Profiel KNMG Jeugdarts)',
71 => 'Spoedeisendehulp (Profiel SEH Arts KNMG)',
74 => 'Sportgeneeskunde',
75 => 'Openbaar apotheker',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this one to Openbare Farmacie. The SOAP response of http://webservices.cibg.nl/Ribiz/OpenbaarV4.asmx?op=GetRibizReferenceData returns it that way.

@eriwin
Copy link
Contributor

eriwin commented Nov 25, 2016

I checked the SOAP response of http://webservices.cibg.nl/Ribiz/OpenbaarV4.asmx?op=GetRibizReferenceData and found a small difference. Can you update Openbaar apotheker too?

@kingkorf
Copy link
Contributor Author

kingkorf commented Dec 1, 2016

There we go! 👍

@eriwin eriwin merged commit 95f7118 into waarneembemiddeling:master Dec 1, 2016
@eriwin
Copy link
Contributor

eriwin commented Dec 1, 2016

@kingkorf Thank you very much 👍

@kingkorf
Copy link
Contributor Author

kingkorf commented Dec 2, 2016

Hi Erik, can you do a patch release (2.0.1?) so I can update my composer.json?

@eriwin
Copy link
Contributor

eriwin commented Dec 2, 2016

@kingkorf Yes. The 2.0.1 release is added.

@kingkorf
Copy link
Contributor Author

kingkorf commented Dec 2, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants