Skip to content

Commit

Permalink
use inspect instead of list to check if an image exists
Browse files Browse the repository at this point in the history
  • Loading branch information
oclaussen committed Feb 15, 2020
1 parent 1486500 commit 1dd8d56
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions pkg/container/image.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,19 @@ import (

"github.com/docker/distribution/reference"
"github.com/docker/docker/api/types"
"github.com/docker/docker/api/types/filters"
"github.com/docker/docker/pkg/jsonmessage"
"github.com/docker/docker/registry"
"golang.org/x/net/context"
)

func (c *Container) GetImage() (string, error) {
filter := filters.NewArgs(filters.Arg("reference", c.config.ImageId))
images, err := c.client.ImageList(
context.Background(),
types.ImageListOptions{Filters: filter},
)
ref, err := reference.ParseAnyReference(c.config.ImageId)
if err != nil {
return "", err
}
if len(images) > 0 {
return images[0].ID, nil

if _, _, err := c.client.ImageInspectWithRaw(context.Background(), ref.String()); err == nil {
return ref.String(), nil
}

parsed, err := reference.ParseNormalizedNamed(c.config.ImageId)
Expand Down

0 comments on commit 1dd8d56

Please sign in to comment.