Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sports guesses #229

Closed
WebSpider opened this issue Sep 12, 2015 · 5 comments
Closed

Sports guesses #229

WebSpider opened this issue Sep 12, 2015 · 5 comments

Comments

@WebSpider
Copy link

WebSpider commented Sep 12, 2015

Sports guesses aren't detecting season or episode and Title is mangled due to language detection picking up the event name ... Example Formula1:

$ guessit -t episode "Formula1.2015.Chinese.Grand.Prix.Race.Only.720p.hdtv.x264-SiCKRAGE.mkv"
For: Formula1.2015.Chinese.Grand.Prix.Race.Only.720p.hdtv.x264-SiCKRAGE.mkv
GuessIt found: {
    [1.00] "mimetype": "video/x-matroska",
    [0.60] "videoCodec": "h264",
    [1.00] "container": "mkv",
    [0.18] "language": [
        "zh"
    ],
    [0.24] "title": "Grand Prix Race Only",
    [0.24] "series": "Formula1",
    [0.60] "format": "HDTV",
    [0.60] "releaseGroup": "SiCKRAGE",
    [0.60] "screenSize": "720p",
    [0.60] "year": 2015,
    [1.00] "type": "episode"
}
$ guessit -t episode -P season,episodeList "Formula1.2015.Chinese.Grand.Prix.Race.Only.720p.hdtv.x264-SiCKRAGE.mkv"
$

I would expect the season to be filled with "2015" and episode would make sense if that would be "Chinese Grand Prix" or something similar? Episodes of sports more often have a name than a number..

@Toilal
Copy link
Member

Toilal commented Sep 12, 2015

See #157, command line has changed a bit but idea is still there. Replace season by year.

guessit -t episode --disabled-transformer GuessCountry --disabled-transformer GuessLanguage "Formula1.2015.Chinese.Grand.Prix.Race.Only.720p.hdtv.x264-SiCKRAGE.mkv"
For: Formula1.2015.Chinese.Grand.Prix.Race.Only.720p.hdtv.x264-SiCKRAGE.mkv
GuessIt found: {
    [0.60] "videoCodec": "h264",
    [0.24] "title": "Chinese Grand Prix Race Only",
    [0.60] "screenSize": "720p",
    [1.00] "container": "mkv",
    [0.60] "releaseGroup": "SiCKRAGE",
    [0.60] "format": "HDTV",
    [1.00] "type": "episode",
    [1.00] "mimetype": "video/x-matroska",
    [0.24] "series": "Formula1",
    [0.60] "year": 2015
}

Currently there's no special code for sport events ... And we can't just replace year by season in this case, because of remake of series like V 2009 => V.2009.S01E01.PROPER.HDTV.XviD-NoTV.mkv

guessit -t episode "V.2009.S01E01.PROPER.HDTV.XviD-NoTV.mkv"For: V.2009.S01E01.PROPER.HDTV.XviD-NoTV.mkv
GuessIt found: {
    [0.60] "format": "HDTV",
    [0.60] "releaseGroup": "NoTV",
    [0.60] "other": [
        "Proper"
    ],
    [0.60] "episodeNumber": 1,
    [0.60] "season": 1,
    [1.00] "mimetype": "video/x-matroska",
    [0.60] "year": 2009,
    [1.00] "type": "episode",
    [1.00] "properCount": 1,
    [0.60] "videoCodec": "XviD",
    [1.00] "container": "mkv"
}

@WebSpider
Copy link
Author

WebSpider commented Sep 12, 2015

Sports are pretty well documented in scene rules, and releasers seem to adhere pretty well to it (at least for f1 and wrestling), suggestion to add code for it?

@Toilal
Copy link
Member

Toilal commented Sep 12, 2015

If you can provide links on those documentation it would be great.

i'm thinking about rewriting guessit from scratch to support various "rules set" like "episodes", "audio", "sports", and maybe others. I'll open another issue about that to engage the discussion.

@WebSpider
Copy link
Author

@Toilal
Copy link
Member

Toilal commented Aug 31, 2019

I'm closing this one, as it will probably never happen.

@Toilal Toilal closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants