added phone field in print_user function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waclawthedev
force-pushed
the
add_phone_field_to_print
branch
from
8db959c
to
a820593
Compare
waclawthedev
commented
Jan 24, 2024
| with open(filename, "w") as file: | ||
| json.dump(user_data, file, indent=4) | ||
|
|
||
|
|
||
| def read_user_from_file(filename): | ||
| def read_user_from_file(filename: str) -> dict: | ||
| with open(filename, "r") as file: |
There was a problem hiding this comment.
Add exception handling for case of non-existing file
waclawthedev
commented
Jan 24, 2024
| name = user["results"][0]["name"] | ||
| print(f"Name: {name['title']} {name['first']} {name['last']}") | ||
| email = user["results"][0]["email"] | ||
| print(f"Email: {email}") | ||
| phone = user["results"][0]["phone"] |
There was a problem hiding this comment.
Avoid directly getting elements and fields from dictionary. Make it safe here and everywhere in this function. Refactor this function.
waclawthedev
commented
Jan 24, 2024
| @@ -2,26 +2,28 @@ | |||
| import requests | |||
|
|
|||
|
|
|||
| def fetch_random_user(): | |||
| def fetch_random_user() -> dict: | |||
| response = requests.get("https://randomuser.me/api/") | |||
There was a problem hiding this comment.
measure and print how much time get request took
waclawthedev
commented
Jan 25, 2024
| @@ -1,2 +1,2 @@ | |||
| # demo_repo_for_gptmypr | |||
| Sample project to practice using gptmypr tool | |||
| Sample project to practice using gptmypr tool (https://github.com/waclawthedev/GPTmyPR) | |||
There was a problem hiding this comment.
Tell more about GPT (2 sentences)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.