-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors are not picked up when content is from clipboard instead of pipe #8
Comments
Hey try #9. But not sure i follow about the missing rear hoof? :) is there some difference between the |
Strange, can you try https://raw.githubusercontent.com/wader/ansisvg/master/ansitosvg/testdata/cowsay-osc-colon-color.ansi.svg Looks like this with firefox 120.0.1 on macos for me |
Huh ok so maybe the OSC skipping fixed it? the one that was broken above was that ansi-copied.txt or ansi-piped.txt? |
(ffcat will end up using inkscape png export) |
Both were broken on Firefox ;) not sure why the OSC skipping fixed the latter, since it shouldn't contain OSC sequences. |
Yeap weird, should be unrelated. But what verison of ansisvg was that? some version of #7? feels more likely a newer version of that one fixed it |
It was the |
Mm guess so. That was not with also the old consolidate text patch? that one i could probably have messed so that the last character was missing :) Anyways so now your kitty keybinding workflow work as intended? also a bit curious what you use ansisvg for? i've mostly used to produce demo screenshots for markdown and for presentations |
No it was created with the version that just uses
Will test later and let u know, thanks.
I also intend to use it for markdown documentation. I used HTML copies of console text (earlier, with GNOME terminal, the "copy as HTML" feature - now, with kitty, the ansi-clipboard feature coupled to ansi2html). |
Ok! sorry for being confused, i blame it's early here!
👍
I see. One annoying thing with SVG is that when used as an image in a HTML and markdown you usually can't select text in the SVG :( but i hope it works out for your use case. Let me know if you use it for something that is public! fun to see Yes after working on ansisvg my illusion of SVG being a graphics format that should look the same everywhere have sadly been a bit shattered a bit :) but now knowing how it actually works it's kind of inevitable that font will be difficult. I guess converting fonts to some simpler svg primitives is probably needed to be even more portable. BTW will think about and have a look at #4 later this week |
@patrislav1 had time to test kitty keybinding? |
I work at a research institute that does a lot of publishing (code, papers, presentations...) so it's actually quite likely that I'll publish stuff generated by your tool, sooner or later! Will keep you posted |
👍
You mean some of the "arrows" looks wrong? strange that some of them are correct but not others. I can try reproduce it, or can you post the ansi input? have a feeling it's something not too tricky to fix. |
Oh elementary physics? i'm a sucker for reading about particle accelerators so happy to see it's being useful at such places! |
I’ll gather some data and open a separate issue. I also noted that the filled background position is off, making the arrows look misaligned. Will try to fix the positions when time permits. |
Steps to reproduce:
Expected:
ansi-piped/copied.svg should look the same
Observed:
ansi-copied.svg misses the coloring and adds some undecoded ESC sequence at the top.
ansi-piped.txt
ansi-copied.txt
The text was updated successfully, but these errors were encountered: