mp4: Better description for QuickTime terminator atom

Addition improvement could be to only allow it in quicktime ftyp brand and also not as a root book. Currently trailing zero bytes could be mistaken as a terminator atom.
wader · May 1, 2023 · 7adc1e7 · 7adc1e7
1 parent 94834c0
commit 7adc1e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/format/mp4/desc.go b/format/mp4/desc.go
@@ -330,5 +330,5 @@ var boxDescriptions = scalar.StrMapDescription{
 	"©wrn": "Warning",
 	"©xyz": "Location",
 
-	"\x00\x00\x00\x00": "Terminator Atom",
+	"\x00\x00\x00\x00": "QuickTime terminator atom",
 }
diff --git a/format/mp4/testdata/in24.fqtest b/format/mp4/testdata/in24.fqtest
@@ -225,7 +225,7 @@ $ fq dv in24.mp4
      |                                               |                |                                    [2]{}: box 0x34f-0x356.7 (8)
 0x340|                                             00|               .|                                      size: 8 0x34f-0x352.7 (4)
 0x350|00 00 08                                       |...             |
-0x350|         00 00 00 00                           |   ....         |                                      type: "\x00\x00\x00\x00" (Terminator Atom) 0x353-0x356.7 (4)
+0x350|         00 00 00 00                           |   ....         |                                      type: "\x00\x00\x00\x00" (QuickTime terminator atom) 0x353-0x356.7 (4)
      |                                               |                |                                      data: raw bits 0x357-NA (0)
      |                                               |                |                                [1]{}: box 0x357-0x36e.7 (24)
 0x350|                     00 00 00 18               |       ....     |                                  size: 24 0x357-0x35a.7 (4)