bitcoin: fix witness item structs #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks! do you have a small test case file you could add? it's usually just add the file to |
This commit fixes witness item decoding such that they are represented as structs with `item_size` and `item` fields, instead of a flat list of raw bytes.
Rogach
force-pushed
the
pr/bitcoin-tx-witness-items
branch
from
ab1532d
to
a3361e7
Compare
|
Added a test. |
|
Great, thanks! will merge once CI is green. There seems to be some hopefully temporary issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes witness item decoding such that they are represented as structs with
item_sizeanditemfields, instead of a flat list of raw bytes.