Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgpack: Add decoder #69

Merged
merged 1 commit into from
Jan 10, 2022
Merged

msgpack: Add decoder #69

merged 1 commit into from
Jan 10, 2022

Conversation

wader
Copy link
Owner

@wader wader commented Jan 10, 2022

Fixes #25

Copy link

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a functionality standpoint, this looks great to me. Built locally and given a saved msgpack data file, I was able to decode using d, tovalue, and msgpack_torepr with helpful output. Thank you, @wader!

@wader
Copy link
Owner Author

wader commented Jan 10, 2022

👍 Great, thanks for testing. I hope to make the *_torepr things simpler in the future, currently thinking there should be a torepr function that automatically converts to a representation if the format supports it. Then the usage would be fq torepr file or maybe even some command line flag.

@wader wader merged commit 05df5a9 into master Jan 10, 2022
@wader wader deleted the msgpack branch January 10, 2022 20:39
@wader
Copy link
Owner Author

wader commented Jan 10, 2022

And let me know if something seems to behave strange, i'm not very familiar with msgpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for MessagePack (msgpack)
2 participants