Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sgpd box entries parsing #707

Merged
merged 1 commit into from
Jun 21, 2023
Merged

sgpd box entries parsing #707

merged 1 commit into from
Jun 21, 2023

Conversation

ksa-real
Copy link
Contributor

@ksa-real ksa-real commented Jun 20, 2023 •
edited

Previously entries were parsed as raw bytes, now KIDs/IVs are explicitly parsed.

@ksa-real ksa-real changed the title sgpd box parsing sgpd box entries parsing Jun 20, 2023
wader
wader reviewed Jun 20, 2023
View reviewed changes
format/mp4/boxes.go Outdated Show resolved Hide resolved
@wader
Copy link
Owner

wader commented Jun 20, 2023

Thanks! hade some minor comments

@ksa-real
sgpd box entries parsing
e869d8a 
Previously entries were parsed as raw bytes, now KIDs/IVs are
explicitely parsed.
@wader
Copy link
Owner

wader commented Jun 21, 2023

LGTM, thanks!

@wader wader merged commit c23e241 into wader:master Jun 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wader wader wader left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ksa-real @wader