make libfdk-aac opt-in to avoid license issues #341
Conversation
Signed-off-by: Gustav Grusell <gustav.grusell@eyevinn.se>
Dockerfile
Outdated
| @@ -770,8 +772,8 @@ RUN \ | |||
| --disable-ffplay \ | |||
| --enable-static \ | |||
| --enable-gpl \ | |||
| --enable-version3 \ | |||
| --enable-nonfree \ | |||
| --enable-version3 \ | |||
There was a problem hiding this comment.
weird indent? i guess we use auto formatters with different opinions? :)
There was a problem hiding this comment.
Ah missed that, will fix.
|
Thanks! i was thinking that maybe the CI PR build should build with |
|
Maybe not a big deal but with this we will still always download/build fdkaac. I've done various experiments before to make all libs optional, and have a default to build al., But it's tricky do to in a way that you don't end up with ex frankenstein Dockerfile that is hard to have a overview of, i really like how clean and simple the current one is. |
|
I agree it could make sense to build with libfdk-aac enabled in the CI to verify that that works. Do you want me to update this in the PR? Yes, I thought it wasn't worth it to complicate things by making the actual build of the libfdk-aac opt-in, I assume it won't add much to the build time anyway. |
Yeap do that
Agree, let's keep it simple for now and we can fix in later if something more generic is done |
Signed-off-by: Gustav Grusell <gustav.grusell@eyevinn.se>
Signed-off-by: Gustav Grusell <gustav.grusell@eyevinn.se>
|
PR updated as discussed. |
|
Looks good. Ready to merge? |
|
Tack! |
No description provided.