The find method will now return nil when a note

doesn't exist. Added the find! method which will raise a CatchNotes::NotFound error.
wadewest · Nov 7, 2010 · 80534fb · 80534fb
1 parent 595d90d
commit 80534fb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/catch_notes/base.rb b/lib/catch_notes/base.rb
@@ -54,12 +54,18 @@ def all
           end
         end
 
-        def find(id)
+        def find!(id)
           res = get "/notes/#{id}"
           if send(:ok?, res)
             send :build_from_hash, res.parsed_response['notes'].first
           end
         end
+
+        def find(id)
+          find!(id)
+        rescue CatchNotes::NotFound
+          nil
+        end
 
         def first
           all.first

diff --git a/test/test_catch_notes.rb b/test/test_catch_notes.rb
@@ -60,9 +60,14 @@ def setup
     assert !note.destroy
   end
 
-  should "raise a NotFound error when a note doesn't exist" do
+  should "raise a nil error when a note doesn't exist: find" do
+    assert_nil NoteClass.find 13
+  end
+
+
+  should "raise a NotFound error when a note doesn't exist: find!" do
     assert_raise CatchNotes::NotFound do
-      NoteClass.find 13
+      NoteClass.find! 13
     end
   end