fix handling of ad hoc csv file header #1057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056
For ad-hoc csv files, read.myacc.csv() returns the header arranged in rows, but g.inspectfile() was trying to access header rows as if they were columns, like this:
header$sample_rate
. I modified the code to correctly access the sample rate as a row of the header object.In addition, g.inspectfile() was trying to process a header returned by read.myacc.csv() the same way it processes an Actigraph cvs header, which caused this module to crash, because a header returned by read.myacc.csv() has a different format.
Also removed the checks for rmc.bitrate and rmc.dynamic_range to be numeric -- both of these can be character strings if these values are to be read from the header.
Plus some minor cleanup.
Checklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
file, if you think you made a significant contribution.