Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134
This includes a revision of the SPT definition when
relyonguider
is set to TRUE.In the original approach, SIB start and end time for the first and last SIB being part of the SPT was modified so that it matched the guider definition. It did not work well at finding the first and last SIB of the SPT. Additionally, this has the challenge that SIB times are modified without keeping track of that, I thought it would be good to leave SIB as they are detected to facilitate methodological research on SPT and SIBs.
In this proposal, when
relyonguider = TRUE
, it does only affect the SPT definition without modifying the times of the SIBs.