-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expandtests #41
Merged
Merged
Expandtests #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th sleeplog file included
…d to a separate function
…e fixed to getfolderstructure function
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
===========================================
+ Coverage 2.55% 56.71% +54.15%
===========================================
Files 49 53 +4
Lines 7546 7705 +159
===========================================
+ Hits 193 4370 +4177
+ Misses 7353 3335 -4018
Continue to review full report at Codecov.
|
m-patterson
pushed a commit
to m-patterson/GGIR
that referenced
this pull request
May 11, 2020
Expandtests
TavoloPerUno
pushed a commit
to TavoloPerUno/GGIR
that referenced
this pull request
Jul 8, 2021
Expandtests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a bit of mixture of new features. Sorry about that, next time I will try to make separate pull requests for separate functionalities. Below I have summarized the changes/additions I made:
I wrote tests and documentation files for all the new functions
The collection of tests GGIR currently has are a crude check that the code performs consistently. Next step will be to thoroughly review every single function and write additional tests to improve test coverage and make sure that all possible scenarios are covered.
Vincent