Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expandtests #41

Merged
merged 147 commits into from
Jul 24, 2017
Merged

Expandtests #41

merged 147 commits into from
Jul 24, 2017

Conversation

vincentvanhees
Copy link
Member

This pull request is a bit of mixture of new features. Sorry about that, next time I will try to make separate pull requests for separate functionalities. Below I have summarized the changes/additions I made:

  • Codecov badge added to the README file. This tells us the extend to which the code is covered by tests
  • Functions added to create dummy accelerometer file (csv) and a dummy sleeplog (csv), needed for testing
  • Default IVIS_epochsize_seconds parameter updated from 30 to 3600, the metric is still not perfectly compatible with the originally published metric, but at least this is one step closer to the original design
  • I condensed the amount of characters printed on screen when running g.calibrate and g.getmeta. The message ‘loading block’ will now only be printed once followed by just the numbers of the blocks separated by spaces rather than new lines.
  • Function g.part5 is too long, so I made a beginning with moving parts of the code to separate functions: getfolderstructure() and identify_level() are new now.
  • I replaced “Europe/London” in g.part5 by desiredtz, to make the function work for users outside the UK
  • Data.frame output is now tidied up at the end of g.part5: entirely empty rows and columns are removed
    I wrote tests and documentation files for all the new functions

The collection of tests GGIR currently has are a crude check that the code performs consistently. Next step will be to thoroughly review every single function and write additional tests to improve test coverage and make sure that all possible scenarios are covered.
Vincent

@codecov-io
Copy link

Codecov Report

Merging #41 into master will increase coverage by 54.15%.
The diff coverage is 96.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #41       +/-   ##
===========================================
+ Coverage    2.55%   56.71%   +54.15%     
===========================================
  Files          49       53        +4     
  Lines        7546     7705      +159     
===========================================
+ Hits          193     4370     +4177     
+ Misses       7353     3335     -4018
Impacted Files Coverage Δ
R/g.analyse.R 83.25% <ø> (+83.25%) ⬆️
R/g.part2.R 62.28% <ø> (+62.28%) ⬆️
R/g.report.part2.R 63.79% <ø> (+63.79%) ⬆️
R/g.plot.R 78.04% <ø> (+78.04%) ⬆️
R/create_test_acc_csv.R 100% <100%> (ø)
R/create_test_sleeplog_csv.R 100% <100%> (ø)
R/identify_level.R 100% <100%> (ø)
R/g.getmeta.R 68.02% <100%> (+68.02%) ⬆️
R/g.calibrate.R 79.03% <100%> (+79.03%) ⬆️
R/g.part5.R 89.41% <81.08%> (+89.41%) ⬆️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34dc247...bf6bb83. Read the comment docs.

@jhmigueles jhmigueles merged commit 2322124 into master Jul 24, 2017
@vincentvanhees vincentvanhees deleted the expandtests branch July 27, 2017 08:04
m-patterson pushed a commit to m-patterson/GGIR that referenced this pull request May 11, 2020
vincentvanhees pushed a commit that referenced this pull request Jun 18, 2020
TavoloPerUno pushed a commit to TavoloPerUno/GGIR that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants