Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New object defaultGuider not defined for all possible scenarios in part 4 #1095

Closed
vincentvanhees opened this issue Mar 28, 2024 · 1 comment · Fixed by #1096
Closed

New object defaultGuider not defined for all possible scenarios in part 4 #1095

vincentvanhees opened this issue Mar 28, 2024 · 1 comment · Fixed by #1096
Assignees
@vincentvanhees
Labels
sleep (GGIRpart3+4)

Comments

@vincentvanhees
Copy link
Member

Following google group report here. Itseems the problem is that object defaultGuider added in this commit was only defined for one specific scenario in part 4. I am now preparing a PR.
@vincentvanhees vincentvanhees self-assigned this Mar 28, 2024
vincentvanhees added a commit that referenced this issue Mar 28, 2024
@vincentvanhees
Ensures defaultGuider is always defiined, fixes #1095
05f0e9b
@vincentvanhees vincentvanhees mentioned this issue Mar 28, 2024
Merged
22 tasks
@vincentvanhees
Copy link
Member Author

For completeness, this issue was introduced in this PR: #1067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentvanhees vincentvanhees

Labels
sleep (GGIRpart3+4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define defaultGuider in each scenario wadpac/GGIR
1 participant
@vincentvanhees