Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1043 SPT and ignore nonwear #1067

Merged
merged 19 commits into from
Feb 28, 2024
Merged

Issue1043 SPT and ignore nonwear #1067

merged 19 commits into from
Feb 28, 2024

Conversation

jhmigueles
Copy link
Collaborator

@jhmigueles jhmigueles commented Feb 26, 2024

Closes issue #1043

This PR adds a new option for HASPT.ignore.invalid, if this parameter is set to NA, then invalid time segments are considered no movement for the Sleep Period Time definition. This addresses those scenarios in which participants unexpectedly take off the devices during nigth even though they are not expected to do so, and this also facilitates the SPT definition in day-only study protocols in which devices are taken off during nights.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

@jhmigueles jhmigueles changed the title Issue1043 sp tnonwear Issue1043 SPT and ignore nonwear Feb 26, 2024
@vincentvanhees
Copy link
Member

I just merged the latest updates in #1063

Copy link
Member

@vincentvanhees vincentvanhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jairo, a few comments based on reading through the changes. I have not tested this PR yet.

R/HASPT.R Outdated Show resolved Hide resolved
R/g.part4.R Show resolved Hide resolved
@vincentvanhees vincentvanhees merged commit c59f56d into master Feb 28, 2024
10 checks passed
@vincentvanhees vincentvanhees deleted the issue1043_SPTnonwear branch February 28, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants