Map special characters in KeyPressPattern #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyPressPattern can either be a `ConsoleKey` or a `char` -- in the ConsoleKey case this PR adds a 'best effort' conversion of the ConsoleKey to a char. This is very similar to the [conversion that PSReadLine does](https://github.com/PowerShell/PSReadLine/blob/ad74cef2501709d2a60a58f61d7cac32d185209f/PSReadLine/Keys.cs#L31-L58), so although this is merely best effort I think it should be sufficient. This change is ultimately required by CSharpRepl because the Roslyn Completion API works on characters ([example](https://github.com/dotnet/roslyn/blob/777f4e0a58eda195a6c66a0327267b16bbbf8f9d/src/EditorFeatures/Core/IntelliSense/AsyncCompletion/Helpers.cs#L77-L134)), not ConsoleKey, so to do some configuration of the Roslyn Completion API we need to know the character that the user has configured for completion, not just the ConsoleKey.
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
=======================================
- Coverage 89.1% 89.0% -0.1%
=======================================
Files 39 39
Lines 2786 2798 +12
Branches 427 428 +1
=======================================
+ Hits 2483 2492 +9
- Misses 197 199 +2
- Partials 106 107 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyPressPattern can either be a
ConsoleKeyor achar-- in the ConsoleKey case this PR adds a 'best effort' conversion of the ConsoleKey to a char. This is very similar to the conversion that PSReadLine does, so although this is merely best effort I think it should be sufficient.This change is ultimately required by CSharpRepl because the Roslyn Completion API works on characters (example), not ConsoleKey, so to do some configuration of the Roslyn Completion API we need to know the character that the user has configured for completion, not just the ConsoleKey.