if the control modifier is pressed, don't insert the character #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #252 +/- ##
=====================================
Coverage 85.1% 85.1%
=====================================
Files 45 45
Lines 3851 3851
Branches 594 594
=====================================
+ Hits 3278 3279 +1
+ Misses 435 433 -2
- Partials 138 139 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This caused a regression. On non-qwerty layouts (like AZERTY, and probably others), when the user tries to type a curly brace, which on that keyboard layout is accomplished by typing ALT-4 (AltGr 4), |
waf
added a commit
that referenced
this pull request
Jun 24, 2023
Previously, PR #252 was attempting to fix the scenario where users can have a Control-Alt-Space keybinding; the keybinding would be fired but the space key would be erroneously typed. However, that PR broke AltGr handling. It assumed that filtering Ctrl to detect keybindings would be OK, and Alt keys would be unaffected. This is not correct, though, because AltGr is represented via Ctrl-Alt, so it actually broke every AltGr based character, like curly-brace on AZERTY keyboards. This commit undoes the original fix for PR #252 and fixes it in a better way. Instead of assuming Ctrl is a keybinding, we use the actual configured keybindings in the filter, rather than assuming Ctrl represent a keybinding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the user sets up a keybinding like Ctrl-Alt-Space, a literal space will be typed into the prompt before firing the keybinding.
The fix is to not insert the character if Control is pressed. We still insert if Shift or Alt is pressed as these can result in valid letters.