Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid history entries #267

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Handle invalid history entries #267

merged 1 commit into from
Jul 30, 2023

Conversation

waf
Copy link
Owner

@waf waf commented Jul 30, 2023

Skip over invalid history entries. Before this change the entire prompt crashed.

Fixes #266

Skip over invalid history entries. Before this change the entire prompt crashed.

Fixes #266
@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Merging #267 (2b19fdd) into main (066221d) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #267   +/-   ##
=====================================
  Coverage   85.0%   85.1%           
=====================================
  Files         46      46           
  Lines       3914    3925   +11     
  Branches     600     601    +1     
=====================================
+ Hits        3330    3341   +11     
  Misses       445     445           
  Partials     139     139           
Files Changed Coverage Δ
src/PrettyPrompt/History/HistoryLog.cs 94.4% <100.0%> (+0.4%) ⬆️

@waf waf merged commit b573889 into main Jul 30, 2023
2 checks passed
@waf waf deleted the handle-invalid-history-entries branch July 30, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-base64 string in prompt-history causes unhandled exception
1 participant