This repository has been archived by the owner on Oct 6, 2018. It is now read-only.
Feature: Music Profiles #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could also close #16, as the bullet points in @Woodenhead's comment should be their own feature tasks. |
| if generated_artist_slug != artist_slug: | ||
| return redirect("music_view_artist", artist_slug=generated_artist_slug) | ||
|
|
||
| results = discog.search(artist_name, search_type="artist") |
There was a problem hiding this comment.
A better naming would probably be response, since you lookup "results" key in the next few lines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small feature to allow last.fm-style URLs of the form e.g.:
http://localhost:8080/music/Neutral+Milk+Hotel/
http://localhost:8080/music/Avril+Lavigne/Let+Go/
for the band Neutral Milk Hotel and Avril Lavigne's album Let Go, respectively. In the event that the artist is not immediately found, we redirect to a (currently non-functional) search page.
This is pretty basic and the artist/master comparison could definitely be improved, but at least it's a starting point for future iteration. It's also useful for the upload flow I'm working on.