new subcards api and list/listed_by relations #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A way to establish has_many relations. The pattern is as follows: Let A,B be cards of type letter and 1,2 cards of type number. If you create list cards - A+numbers -> [[1]]\n[[2]] - B+numbers -> [[1]] then the following listed_by cards will contain the related letters: - 1+letters -> [[A]]\n[[B]] - 2+letters -> [[A]]] The content of listed_by cards is cached and gets updated after every change on a related list card.
Conflicts: card/lib/card/set.rb card/mod/01_core/set/all/phases.rb card/mod/01_core/set/all/tracked_attributes.rb card/mod/01_core/spec/set/all/tracked_attributes_spec.rb card/mod/02_basic_types/set/all/base.rb card/mod/05_standard/set/abstract/attachment.rb card/mod/05_standard/set/right/account.rb card/mod/05_standard/set/self/navbox.rb card/mod/05_standard/set/self/signin.rb card/mod/05_standard/set/type/signup.rb card/mod/05_standard/set/type/user.rb card/mod/05_standard/spec/set/all/account_spec.rb
| # | ||
| # end | ||
|
|
||
| end |
There was a problem hiding this comment.
I don't know why the wagn logo changed. I'll restore the old version.
| it 'reader setting' do | ||
| Card.where(trash: false).each do |ca| | ||
| rule_card, rule_class = ca.permission_rule_card(:read) | ||
| # warn "C #{c.inspect}, #{c.read_rule_id}, #{prc.first.id}, #{c.read_rule_class}, #{prc.second}, #{prc.first.inspect}" unless prc.last == c.read_rule_class && prc.first.id == c.read_rule_id |
| if name && t=template | ||
| reset_patterns #still necessary even with new template handling? | ||
| def get_type_id_from_structure | ||
| if name && (t = template) |
There was a problem hiding this comment.
Use a guard clause instead of wrapping the code inside a conditional expression.
| before do | ||
| @card = Card['A'] | ||
| end | ||
| subject { Card.fetch("#{@card.name}+sub", new: {}, local_only: true).content } |
| @@ -102,14 +102,14 @@ Style/CollectionMethods: | |||
| PreferredMethods: | |||
| collect: map | |||
| collect!: map! | |||
| find: detect | |||
There was a problem hiding this comment.
nice thing about detect is that you wouldn't confuse it with ActiveRecord#find...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "list" and "listed by" cardtypes provide a way to establish many-to-many relationships. The pattern is as follows:
Let A,B be cards of type letter and 1,2 cards of type number.
If you create list cards
then the following listed by cards will contain the related letters:
The content of listed by cards is cached and gets updated after every change on a related list card.