S2050 Refactor Submission.java #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for regular expression matching
Read submission tests
Merging Paul's MySQL test files and bug fixes
…noring extra sql statements before parsing first question
…SQL and Oracle Folders with sample folders for MySQL as well as the previous Oracle sample files are provided, though now in separate subfolders. Files folder now emptied, user must copy files from one of two sample folders for testing. assignmentProperties sample files provided for both Oracle and MySQL (some SQL dialect differences illustrated). Install and Usage docs updated accordingly.
1) Fix bug to make result sets scrollable (needed for testResultSetEqualContent); 2) Use newer driver class to avoid warnings, and 3) set up port variable to allow possibility of running MySQL server on other ports than 3306
Getting update to test files
Refactoring in readsubmission
Added some more tests to increase the coverage on readSubmission()
|
Refactoring of readSubmission() method in Submission class as part of NCSU class project S2050 and accompanying tests now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project focuses on redesigning and rewriting one large method that parses one student submission file and builds a data structure for later evaluation.
Contributors: