Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for signed-off-by doesn't ignore comments #187

Closed
iamniting opened this issue Jul 1, 2021 · 6 comments
Closed

Check for signed-off-by doesn't ignore comments #187

iamniting opened this issue Jul 1, 2021 · 6 comments

Comments

@iamniting
Copy link

Same as conventional-changelog/commitlint#1809
Fix: conventional-changelog/commitlint#2098

Can we get this change in the action? I am also getting the same issue.

Screenshot from 2021-07-01 14-24-04
@wagoid wagoid closed this as completed in 9e5880e Jul 15, 2021
@wagoid
Copy link
Owner

wagoid commented Jul 15, 2021 •
edited

Hey @iamniting! Issue is now fixed on v4 👍

@iamniting
Copy link
Author

Cool thanks @wagoid

iamniting added a commit to iamniting/odf-operator that referenced this issue Jul 15, 2021
@iamniting
action: update commitlint version
c3134c5 
fix Check for signed-off-by doesn't ignore comments
wagoid/commitlint-github-action#187.
iamniting added a commit to iamniting/odf-operator that referenced this issue Jul 15, 2021
@iamniting
action: update commitlint version
3995570 
fix Check for signed-off-by doesn't ignore comments
wagoid/commitlint-github-action#187.
iamniting added a commit to iamniting/odf-operator that referenced this issue Jul 15, 2021
@iamniting
action: update commitlint version
476c51e 
fix Check for signed-off-by doesn't ignore comments
wagoid/commitlint-github-action#187.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
iamniting added a commit to iamniting/odf-operator that referenced this issue Jul 15, 2021
@iamniting
action: update commitlint version
24d169d 
fix Check for signed-off-by doesn't ignore comments
wagoid/commitlint-github-action#187.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
iamniting added a commit to iamniting/odf-operator that referenced this issue Jul 15, 2021
@iamniting
action: update commitlint version
3e85400 
fix Check for signed-off-by doesn't ignore comments
wagoid/commitlint-github-action#187.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
Copy link
Author

@wagoid It is still failing.
Screenshot from 2021-07-15 18-38-43

result link https://github.com/iamniting/odf-operator/runs/3076882169?check_suite_focus=true

@wagoid
Copy link
Owner

wagoid commented Jul 15, 2021

Interesting, I'm up to date with commitlint packages but it still fails. Also, I've not tested this behavior completely🤦‍♂️. I just tested that it would not break with the signed off message, but didn't add a test for a config file that requires signed-off-by rule.

Will have a look and get back to you 👍

@wagoid wagoid reopened this Jul 15, 2021
@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this issue Aug 11, 2021
Merged
@wagoid wagoid closed this as completed in 961b6d4 Sep 11, 2021
@wagoid
Copy link
Owner

wagoid commented Sep 11, 2021

@iamniting Now this should be completely fixed! 💪

@iamniting
Copy link
Author

Thanks @wagoid It is fixed now.

iamniting added a commit to iamniting/odf-operator that referenced this issue Sep 15, 2021
@iamniting
action: Fix the commitlint action for signed-off
03fedfa 
reference:
wagoid/commitlint-github-action#187

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting mentioned this issue Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagoid @iamniting