Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action is broken as of 1/25/2024 by upstream shenanigans #755

Closed
pdehlke opened this issue Jan 25, 2024 · 2 comments · Fixed by #760
Closed

Action is broken as of 1/25/2024 by upstream shenanigans #755

pdehlke opened this issue Jan 25, 2024 · 2 comments · Fixed by #760

Comments

@pdehlke
Copy link

pdehlke commented Jan 25, 2024

commitlint did this this morning:

conventional-changelog/commitlint#3871

And now this action is failing all over with

Error: You have commit messages with errors

error running commitlint
Found invalid rule names: header-trim. Supported rule names are: body-case, body-empty, body-full-stop, body-leading-blank, body-max-length, body-max-line-length, body-min-length, footer-empty, footer-leading-blank, footer-max-length, footer-max-line-length, footer-min-length, header-case, header-full-stop, header-max-length, header-min-length, references-empty, scope-case, scope-empty, scope-enum, scope-max-length, scope-min-length, signed-off-by, subject-case, subject-empty, subject-full-stop, subject-max-length, subject-min-length, subject-exclamation-mark, trailer-exists, type-case, type-empty, type-enum, type-max-length, type-min-length
RangeError: Found invalid rule names: header-trim. Supported rule names are: body-case, body-empty, body-full-stop, body-leading-blank, body-max-length, body-max-line-length, body-min-length, footer-empty, footer-leading-blank, footer-max-length, footer-max-line-length, footer-min-length, header-case, header-full-stop, header-max-length, header-min-length, references-empty, scope-case, scope-empty, scope-enum, scope-max-length, scope-min-length, signed-off-by, subject-case, subject-empty, subject-full-stop, subject-max-length, subject-min-length, subject-exclamation-mark, trailer-exists, type-case, type-empty, type-enum, type-max-length, type-min-length
at Object.lint [as default] (/node_modules/@commitlint/lint/lib/lint.js:53:15)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async /run.js:302:17
at async Promise.all (index 0)
at async showLintResults (/run.js:301:25)

I'm not good enough with the twisty maze that is the world of npm dependencies to understand how to fix this.

@romainbsl
Copy link

Fixing the version of commitlin to 18.5.0 as worked for me:

    run: yarn add --no-lockfile @commitlint/config-conventional@18.5.0

@wagoid
Copy link
Owner

wagoid commented Mar 28, 2024

Hi @pdehlke! I couldn't replicate the issue, but I'm upgrading commitlint to latest version since @romainbsl mentioned that it has been fixed on 18.5.0. Please let me know if it still doesn't work after the upgrade 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants