Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gocui module #331

Merged
merged 3 commits into from
Jan 2, 2021
Merged

Update gocui module #331

merged 3 commits into from
Jan 2, 2021

Conversation

cxsu
Copy link

@cxsu cxsu commented Dec 27, 2020

I've replaced jroimartin/gocui module to awesome-gocui/gocui and included the wagoodman/keybinding module because it cannot be modified directly. (import awesome-gocui/keybinding)

gocui v1.0.0-beta-2 has been released, and we will be able to meet a better UI.

(Even Windows is supported using termbox! (tcell in v1))

image

@wagoodman
Copy link
Owner

wagoodman commented Jan 2, 2021

Nice, I was wondering when the gocui-tcell enhancements were going to land, happy to see that it happened... thanks, @cxsu !

Also, interesting timing! It just so happens that #326 is also trying to move over to tcell via tview. We should collaborate between these efforts.

@dwillist as I understand it, the main goal behind your PR is to get the view abstractions for CNB analysis to get added to the UI in a particular pane , yes? Given that there is still a lot of work left to do to replicate functionality from gocui to tview (and lots of tests to add back), it may be easier to merge this PR and replicate the analysis portion off of a new branch and get in that functionality. What do you think?

For the meantime I'm going to merge this PR since it moves the main branch forward off of the now unsupported gocui repo.

@wagoodman wagoodman merged commit 6f15b4c into wagoodman:master Jan 2, 2021
@dwillist
Copy link

dwillist commented Jan 9, 2021

@wagoodman Sounds 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants