Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consumer close before run #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johanneswuerbach
Copy link
Contributor

When running consumer.Close before the consumer.Run has finished, Run will never return.

Prevent this by also getting the isClosedMux lock while initialising the handler.

@wagslane
Copy link
Owner

I don't think this is the right fix: it doesn't actually have anything to do with the isClosed variable being racy does it?

@johanneswuerbach
Copy link
Contributor Author

Yes and no. From my understanding Close is essentially trying to signal running consumers that the channel has been closed, but if the startGoroutines wasn't finished yet, this signalling doesn't work and a consumers starts nevertheless.

As Close and Run (or specifically the init part) depend on each other, I think using a shared lock here makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants