notify return safety #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
reviewed
Jul 20, 2021
publish.go
Outdated
| disablePublishDueToFlow: false, | ||
| disablePublishDueToFlowMux: &sync.RWMutex{}, | ||
| logger: options.Logger, | ||
| notifyReturnChan: make(chan Return), |
There was a problem hiding this comment.
We should probably close this channel at some point as well, so consumers can easily range over it. Maybe after the notifyCancelOrClose has been closed, around line 170? A little tricky since we should safeguard (or think/make sure) against the startNotifyReturnHandler having also finished sending to the channel, otherwise it could panic if we close before it's done.
There was a problem hiding this comment.
Leaving a note for myself - It's actually when we call StopPublishing that this kind of cleanup needs to be triggered
marcelmiguel
pushed a commit
to marcelmiguel/go-rabbitmq
that referenced
this pull request
May 30, 2023
notify return safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #30 @victorges can you review this when you have time?