Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

update requirement to account for image chooser dependency #9

Merged
merged 1 commit into from Sep 28, 2018

Conversation

mwesterhof
Copy link
Contributor

This appears to be necessary, I ran into issues when testing react streamfields for an existing wagtail project. Trying to open an image chooser fails with a JS error here

this appears to happen because wagtail-react-streamfield depends on this, which was introduced in wagtail 2.2

@BertrandBordage BertrandBordage added the bug Something isn't working label Sep 28, 2018
@BertrandBordage
Copy link
Contributor

Thank you for pointing that out, @mwesterhof!
I’m trying to fix it in order to make it work with all 2.x versions instead of sticking to 2.2. If I can’t make it, I’ll fallback to your pull request 🙂

@BertrandBordage
Copy link
Contributor

It’s too complex to support both because wagtail-react-streamfield relies on the new onload system introduced in Wagtail 2.2 to asynchronously fetch chooser data and display it.

So I merge your pull request, this project will only support Wagtail 2.2 or more.

@BertrandBordage BertrandBordage merged commit 883d054 into wagtail-deprecated:master Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants