Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wagtail 2.8 Deprecation Warnings #54

Merged

Conversation

loicteixeira
Copy link
Collaborator

Ref #53

@loicteixeira
Copy link
Collaborator Author

loicteixeira commented Jul 19, 2020

The deprecation warning from Wagtail 2.8 was an easy fix.

The one from Wagtail 2.9 might be a bit trickier as request.site is not only used in a template (easy-ish fix) but is also manually hydrated in the API views. I'll need to dig a bit deeper in how the new site/request thing works in order for everything to work the in the new way.

If I can't get to the bottom of it before the start of August, we can still merge this PR so the first deprecation warning (which by Wagtail 2.10 will be breaking) can be addressed.

@loicteixeira loicteixeira marked this pull request as ready for review October 5, 2020 10:55
@loicteixeira loicteixeira changed the title Fix Deprecation Warnings Fix Wagtail 2.8 Deprecation Warnings Oct 5, 2020
@loicteixeira
Copy link
Collaborator Author

Merging this first fix which should bring compatibility with Wagtail 2.10.

@loicteixeira loicteixeira merged commit 5e44c54 into wagtail-nest:master Oct 5, 2020
@loicteixeira loicteixeira deleted the fix/53-deprecation-warnings branch October 5, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant