Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash when checking permissions of external reviewer without shares #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Prevent crash when checking permissions of external reviewer without shares #29

wants to merge 3 commits into from

Commits on Apr 17, 2020

  1. Check for existence of share before checking share.can_comment to pre… 

    …vent exception for external reviewers without shares
    @jacobtoppm
    jacobtoppm committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    28be11c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Make logic around shares and comments clearer

    @jacobtoppm
    jacobtoppm committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3e1206a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Ensure permissions check for superusers returns identical results fro… 

    …m back or frontend
    @jacobtoppm
    jacobtoppm committed Apr 23, 2020
    Configuration menu
    Copy the full SHA
    ee5ef84 View commit details
    Browse the repository at this point in the history