New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial HomePage styling #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming together well, some notes on SCSS best practices and thoughts on the next.js components, Link and Image. Using pixel values instead of rem for margins and padding would be nice, but this is a personal preference - Tailwind uses style rules that are fractions and multiples of rem, so we could follow that convention here as well.
Co-authored-by: James Hancock <jhancock532@gmail.com>
@Tijani-Dia sorry, I should have shared screenshots right away 🤦 here we are. I believe this should be round on the ends: And here is the logo overlapping: |
@thibaudcolas I've addressed the styling issues mentioned in the previous comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I’ve suggested one additional change based on my previous review. Additionally I really think the logo should have been done with inline SVG so we can change its color based on the theme more easily – but since it’s done already let’s wait for dark mode to be added before we change that.
Co-authored-by: Thibaud Colas <thibaudcolas@gmail.com>
Thanks @thibaudcolas. I've done the logo with inline SVG in the following PR. |
Ah nice :) |
Style all hardcoded components in the HomePage