Breadcrumb changes

[hminnovation]

In the sprint I rather hastily created base to be

    <content>
        {% block content-header %}
        {% endblock content-header %}

        {% block breadcrumbs %}
            {% breadcrumbs %}
            {# breadcrumbs is defined in base/templatetags/navigation_tags.py #}
        {% endblock breadcrumbs %}

        {% block content-body %}
        {% endblock content-body %}
    </content>

This allowed breadcrumbs to be nested between the hero image of the design and the main content, but having started properly with the styling it's a brittle solution that's going to be a headache.

I'm moving it back to the more orthodox

{% block breadcrumbs %}
    {% breadcrumbs %}
    {# breadcrumbs is defined in base/templatetags/navigation_tags.py #}
{% endblock breadcrumbs %}

<content>
    {% block content %}
        
    {% endblock content %}
</content>

To do

• Amending relevant template files
• Styling breadcrumb
• Dealing with any merge issues

[shacker]

When I run this branch, all content disappears on the site. Changing the main block from block content to block content-body brings it back, but thumbnail images on locations index go all stretchy. Can you test?

[hminnovation]

Sorry, I should have made it clearer that this branch isn't ready to test yet. I just wanted to create some visibility of the fact it was being done :)

[shacker]

Ah - our work team convention is to put a big DO NOT MERGE flag as top comment on WIP branches that also have PRs.

[hminnovation]

It's ours too. Sorry, entirely my fault for having done this whilst being rushed out the door by an irate partner who didn't want me working on a Saturday :D

So, I think this is now ready to review. The breadcrumbs should look like

(The two images above are with the HTML cherry-picked from branch 51-location-styling-missing-styles because it's otherwise not possible to show the hero image)

I've used a bit of a hack within the CSS .breadcrumb-container + content > .hero to allow the breadcrumb to sit visually above hero images using a negative top-margin, but on pages where there isn't a hero image the breadcrumb will sit above the white background.

There's going to be a lot of conflicts between this and #53 . I would suggest that we merge #53 to master (if no more work required on that PR), then I merge that version of master in to this branch, and resolve the conflicts. Does that sound okay?

[shacker]

LOL, I sure get that about partner not loving this weekend work :)

PR #53 is now merged, so rebase away. This looks really polished - Thanks for all your work on this.

[shacker]

LGTM.

+1 on returning to standard block content.

[hminnovation]

Awesome. Have rebased. @shacker or @daaray if one of you could double check and merge that'd be awesome.

[daaray]

👍