update python/django/wagtail versions #70
Conversation
| "Framework :: Wagtail :: 4", | ||
| "Framework :: Wagtail :: 5", | ||
| ] | ||
| requires-python = ">=3.8" | ||
| dynamic = ["version"] | ||
| dependencies = [ | ||
| "Django>=3.2", | ||
| "Wagtail>=4.1,<6.0" | ||
| "Wagtail>=4.1" |
There was a problem hiding this comment.
I converted this to an open range because now that the version of wagtail on main is 6.0a0, if you try to run the wagtailmain toxenv, pip throws
ERROR: Cannot install wagtail 6.0a0 (from git+https://github.com/wagtail/wagtail.git) and generated-package-name[testing]==0.1.0 because these package versions have conflicting dependencies.
trying to install. Open to other ideas, but I think an open range is reasonable here.
There was a problem hiding this comment.
open range is what I started advocating for
| python{3.8,3.9,3.10,3.11}-django{3.2,4.1,4.2}-wagtail{5.0,5.1,main}-{sqlite,postgres} | ||
| python{3.8,3.9,3.10,3.11}-django{3.2}-wagtail{4.1}-{sqlite,postgres} | ||
| python{3.8,3.9,3.10,3.11}-django{3.2,4.2}-wagtail{5.1,5.2,main}-{sqlite,postgres} | ||
| python{3.12}-django{4.2}-wagtail{5.2,main}-{sqlite,postgres} |
There was a problem hiding this comment.
we normally keep wagtailmain out of the test matrix, deferring to the nightly CI task instead. This is so that we don't get failures against it in the normal course of operations.
Alas, GitHub Actions doesn't have a nice "allow-failures" mode (ref actions/runner#2347)
There was a problem hiding this comment.
if you want to allow tox to run tests against wagtailmain locally, you could add something like
[testenv:wagtailmain]
deps =
git+https://github.com/wagtail/wagtail.gitThere was a problem hiding this comment.
Just to be clear, wagtailmain is not a new target I introduced in this PR
I've dropped it in 9b882ba anyway
this should have been removed in #60
Closes #66
As well as adding the shiny new things, I've taken the opportunity to remove some django/wagtail version which are out of support from the tox matrix, classifiers, etc. I also dropped django 4.1. Technically 4.1 still receives security upgrades for another 2 weeks, but while I've got a bit of time to do this, I think we can just drop it now.