Adopt Ruff #73
Merged
Adopt Ruff #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
commented
Jan 26, 2024
zerolab
reviewed
Jan 26, 2024
|
@chris48s what do you think of adding a separate ruff workflow like https://github.com/torchbox/wagtail-bynder/blob/main/.github/workflows/ruff.yml -- this will add handy inline annotations on the PR should there be failures |
Sounds like a reasonable improvement. It requires us to drop the "delegate all linter management to pre-commit" thing and install our tools in the local environment first, which I do plan to deal with, but I think should be another issue - as stated in the top post. I don't think we need to do all that in this PR for it to be worth merging. |
zerolab
reviewed
Mar 1, 2024
zerolab
reviewed
Mar 1, 2024
zerolab
reviewed
Mar 1, 2024
...ookiecutter.__project_name_kebab }}/{{ cookiecutter.__project_name_snake }}/test/settings.py
Outdated
Show resolved
Hide resolved
zerolab
reviewed
Mar 1, 2024
{{ cookiecutter.__project_name_kebab }}/.pre-commit-config.yaml
Outdated
Show resolved
Hide resolved
zerolab
requested changes
Mar 1, 2024
Co-authored-by: Dan Braghiș <dan@zerolab.org>
…ect_name_snake }}/test/settings.py Co-authored-by: Dan Braghiș <dan@zerolab.org>
Co-authored-by: Dan Braghiș <dan@zerolab.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why not? All the cool kids are doing it 😎
Closes #58
This PR replaces
with ruff, and provides a very similar ruff config to what we previously had for those tools.
In this PR, I have stuck to doing everything with pre-commit hooks and no local installs. I am not making the switch away from hook repos to using "local" here, just to keep the scope constrained. I do plan to do that, but it is another issue for another day.