Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 support (dropping Django 1.8 support ?) #85

Closed
smendes opened this issue Nov 17, 2017 · 3 comments
Closed

Django 2.0 support (dropping Django 1.8 support ?) #85

smendes opened this issue Nov 17, 2017 · 3 comments

Comments

@smendes
Copy link
Contributor

smendes commented Nov 17, 2017

We are using both Wagtail and ModelCluster on a project and after trying to run Django 2.0 Beta 1 I found some issues in ModelCluster.

I've made a few changes locally to make it run:

  • field.rel -> field.remote_field (in django.db.models.fields.Field)
  • field.rel.to -> field.remote_field.model (in django.db.models.fields.reverse_related.ForeignObjectRel)

Looking through the issues I've found your answer in Wagtail's issue #3599. I was wondering if there are any plans to drop the support of Django 1.8 for ModelCluster and move forward with those changes.

And if that's the case I can provide a PR of those changes if you want.

@gasman
Copy link
Contributor

gasman commented Nov 17, 2017

Thanks for investigating this, @smendes! Yes, I think now is the time to drop Django 1.8 support in favour of 2.0. A PR would be very welcome.

@smendes
Copy link
Contributor Author

smendes commented Nov 20, 2017

PR opened #86
To make it work it depends on an update of django-taggit.

Also worth mentioning I've added an empty implementation of _apply_rel_filters that should be compatible with all versions but that can probably be done much better.

@gasman
Copy link
Contributor

gasman commented Feb 12, 2018

Completed in #86.

@gasman gasman closed this as completed Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants