Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 2.0 #509

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Add support for Django 2.0 #509

merged 1 commit into from
Dec 20, 2017

Conversation

jdufresne
Copy link
Member

Add Django 2.0 to the Travis and tox test matrix.

Add Django 2.0 to the list of trove classifiers.

Update TaggableRel for internal API differences of Django 2.0. Guard with a VERSION check where necessary.

@jdufresne
Copy link
Member Author

The test failure is due to the master branch, not Django 2.0. A fix for the travis configuration is in #504.

@aaugustin
Copy link

Thanks, this branch works well, I'm running it in production now.

@hggh
Copy link

hggh commented Dec 8, 2017

@alex could you please merge this Django 2 PR into your master and release a new version of taggit?

@codecov-io
Copy link

codecov-io commented Dec 13, 2017

Codecov Report

Merging #509 into master will decrease coverage by 1.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   89.59%   87.95%   -1.65%     
==========================================
  Files           8        5       -3     
  Lines         673      548     -125     
  Branches      102       96       -6     
==========================================
- Hits          603      482     -121     
+ Misses         55       52       -3     
+ Partials       15       14       -1
Impacted Files Coverage Δ
taggit/managers.py 89.27% <100%> (+0.41%) ⬆️
taggit/migrations/__init__.py
taggit/models.py
taggit/forms.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294fe61...10a2b81. Read the comment docs.

Add Django 2.0 to the Travis and tox test matrix.

Add Django 2.0 to the list of trove classifiers.

Update TaggableRel for internal API differences of Django 2.0. Guard
with a VERSION check where necessary.

Fixes #497
Fixes #511
@nemesifier
Copy link
Collaborator

@jdufresne I've merged #504 and restarted the build

@nemesifier
Copy link
Collaborator

Latest versions of Pytest dropped support for python 3.3, so that build was failing, I pinned down the version of pytest, let's wait for https://travis-ci.org/alex/django-taggit/builds/319130342 to finish.

@nemesifier
Copy link
Collaborator

Ok the python 3.3 build passed after downgrading pytest, I feel confident in merging this now.
BTW I wouldn't mind in dropping support for python 3.3, but I think that decision is not up to me. I'm only an occasional maintainer and I want to operate with the broadest consensus as possible.

@nemesifier nemesifier merged commit 10a2b81 into jazzband:master Dec 20, 2017
nemesifier added a commit that referenced this pull request Dec 20, 2017
Conflicts:
	.travis.yml
	tox.ini
@hggh
Copy link

hggh commented Dec 20, 2017

@nemesisdesign thanks for merging. python 3.3 is eol: https://www.python.org/dev/peps/pep-0398/#x-end-of-life so it's save to drop it.

There is a PR #512

@jdufresne jdufresne deleted the dj20 branch December 20, 2017 12:18
@nemesifier
Copy link
Collaborator

Ok let's do it

repejota added a commit to vtalks/vtalks.net that referenced this pull request Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants