-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Django 2.0 #509
Conversation
The test failure is due to the master branch, not Django 2.0. A fix for the travis configuration is in #504. |
Thanks, this branch works well, I'm running it in production now. |
@alex could you please merge this Django 2 PR into your master and release a new version of taggit? |
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 89.59% 87.95% -1.65%
==========================================
Files 8 5 -3
Lines 673 548 -125
Branches 102 96 -6
==========================================
- Hits 603 482 -121
+ Misses 55 52 -3
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
@jdufresne I've merged #504 and restarted the build |
Latest versions of Pytest dropped support for python 3.3, so that build was failing, I pinned down the version of pytest, let's wait for https://travis-ci.org/alex/django-taggit/builds/319130342 to finish. |
Ok the python 3.3 build passed after downgrading pytest, I feel confident in merging this now. |
Conflicts: .travis.yml tox.ini
@nemesisdesign thanks for merging. python 3.3 is eol: https://www.python.org/dev/peps/pep-0398/#x-end-of-life so it's save to drop it. There is a PR #512 |
Ok let's do it |
Add Django 2.0 to the Travis and tox test matrix.
Add Django 2.0 to the list of trove classifiers.
Update
TaggableRel
for internal API differences of Django 2.0. Guard with aVERSION
check where necessary.