Fix/98 loaddata with parentalmanytomany #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows ParentalManyToMany fields values to be respected when using Django's
loaddatamanagement command.I'm aware that these changes introduce the possibility of developers accidentally modifying the live database by setting the field value to something other than an iterable of objects. But, I cannot really see another way to make this work, as the parent object is not saved again after the manytomanyfield data is loaded. There does not seem to be a way to tell if the method is being called as a result of
loaddataor direct manipulation either, so cannot see a way to make this behaviour conditional. I'm open to ideas on this though :)