Allow formsets to be omitted when ClusterForm.formsets not explicitly passed #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… passed As per wagtail/wagtail#5414 (comment) - wagtail#106 changed the base form class of child forms to ClusterForm, which means that (in the absence of an explicit 'formsets' parameter) they now expect form submissions to contain formsets for every child relation on that model. This breaks some Wagtail setups where child relations exist but are not handled through InlinePanel - e.g tag fields. Here we modify that behaviour so that, if 'formsets' is not explicitly set on the ClusterForm, it silently skips over any formsets missing from the submission, restoring the previous behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per wagtail/wagtail#5414 (comment) - #106 changed the base form class of child forms to ClusterForm, which means that (in the absence of an explicit 'formsets' parameter) they now expect form submissions to contain formsets for every child relation on that model. This breaks some Wagtail setups where child relations exist but are not handled through InlinePanel - e.g tag fields.
Here we modify that behaviour so that, if 'formsets' is not explicitly set on the ClusterForm, it silently skips over any formsets missing from the submission, restoring the previous behaviour.