Test against Django 4.0 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
Jan 6, 2022
There was a problem hiding this comment.
Looks like everything passes, so that's great!
Got two clean up questions:
- re
django40stableintox.iniand.github/workflows/test.yml - with Django 3.2 and 4.0 there are a bunch of
(models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.warnings. May be worth cleaning this up too, since you're in the area :P
| @@ -28,6 +28,7 @@ deps = | |||
| dj30: Django>=3.0,<3.1 | |||
| dj31: Django>=3.1,<3.2 | |||
| dj32: Django>=3.2,<3.3 | |||
| dj40: Django>=4.0,<4.1 | |||
| dj40stable: git+https://github.com/django/django.git@stable/4.0.x#egg=Django | |||
There was a problem hiding this comment.
question: should this be cleaned up now?
There was a problem hiding this comment.
No, it's standard for us to have the current stable branch in our CI runs, to flag up any regressions in an upcoming patch release before they bite us. (Happens very rarely, but has done once or twice!)
|
(leaving the default_auto_field warnings for now, as they only affect the test apps - they won't surface on a correctly-configured real world project.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.