Fix bug when field name collides with filter expression tokens #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the field name collides with one of the filter expression tokens, e.g. when the field name is `day`, it will crash. E.g. `holiday_model.objects.get(day='Friday')`, this function will trigger using `test_day` as the filter expression.
|
Thanks @qge! Please could you add a test for this? |
|
Actually, just realised that this is a duplicate of #172, so will close this for now (but happy to reopen if you can provide a test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the field name collides with one of the filter expression tokens, e.g. when the field name is
day, it will crash.E.g.
holiday_model.objects.get(day='Friday'), this function will trigger usingtest_dayas the filter expression.