switch pk check to test for None #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- models with a pk of 0 cannot be saved with the existing pk check, see https://code.djangoproject.com/ticket/2160
|
Thanks @alee! Please can you update the tests in https://github.com/wagtail/django-modelcluster/tree/master/tests to cover this case? |
|
Sure, would be happy to - is |
|
Yep, that's right. |
- models with a pk of zero should still be able to commit their members (e.g., legacy data imports) - models with None cannot commit their members but `parent.save()` will still work as Django will save a clone of that object (assuming no uniqueness or integrity constraints are violated)
|
Done, though I'm not sure I did a very good job with the tests 😨 The scenario we encountered this in involved a data migration with legacy data that has some instances with a pk of 0. These were converted into a Model that uses django-modelcluster to handle tagging. The instances with a pk of 0 can't be saved from the CLI or wagtail admin because they fail the https://sentry.commons.asu.edu/share/issue/9300febee94c45819c3e1df8cfa61112/ |
|
Thanks again! Merged in 9168a8f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
models with a pk of 0 cannot be saved with the existing pk check, see also
https://code.djangoproject.com/ticket/2160