Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile for Debian Bullseye release #32

Merged
merged 2 commits into from Sep 3, 2021

Conversation

tbrlpld
Copy link
Contributor

@tbrlpld tbrlpld commented Sep 3, 2021

The previously used base image python:3.7 was changed to now use
Debian Bullseye. This lead to installation issues of libenchant-dev
(see #31).

This is now fixed by upgrading the installation command for libenchant
to libenchant-2-dev (see also https://pkgs.org/search/?q=LIBENCHANT).

Additionally, to avoid similar issues in the future, the Debian version
of the base image is now defined in the Dockerfile.

Closes #31

The previously used base image `python:3.7` was changed to now use
Debian Bullseye. This lead to installation issues of `libenchant-dev`
(see wagtail#31).

This is now fixed by upgrading the installation command for `libenchant`
to `libenchant-2-dev` (see also https://pkgs.org/search/?q=LIBENCHANT).

Additionally, to avoid similar issues in the future, the Debian version
of the base image is now defined in the `Dockerfile`.
Dockerfile Show resolved Hide resolved
@tbrlpld tbrlpld requested a review from zerolab September 3, 2021 23:05
@saevarom
Copy link
Collaborator

saevarom commented Sep 3, 2021

I ran a quick docker-compose up and everything seems to work fine. Running again with python 3.8

@saevarom saevarom self-requested a review September 3, 2021 23:13
@saevarom saevarom merged commit 121d6fc into wagtail:master Sep 3, 2021
@tbrlpld
Copy link
Contributor Author

tbrlpld commented Sep 3, 2021

Thank you both for reviewing @zerolab @saevarom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem docker-compose built
3 participants