Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure semantic HTML in layout.html #26

Closed
tbrlpld opened this issue Mar 8, 2021 · 0 comments · Fixed by #52
Closed

Ensure semantic HTML in layout.html #26

tbrlpld opened this issue Mar 8, 2021 · 0 comments · Fixed by #52
Assignees
@tbrlpld
Projects
Wagtail theme switch

Comments

@tbrlpld
Copy link
Collaborator

tbrlpld commented Mar 8, 2021

The Typo3 layout.html is using classes like page-header and page-main on div elements.

We should employ the proper HTML 5 tags that convey that meaning as well, which helps screen readers and other accessibility tools.
@thibaudcolas thibaudcolas added this to Needs triage in Wagtail theme switch Mar 10, 2021
@thibaudcolas thibaudcolas moved this from Needs triage to Nice to have in Wagtail theme switch Mar 10, 2021
@tbrlpld tbrlpld self-assigned this Mar 10, 2021
@tbrlpld tbrlpld moved this from Nice to have to In Progress in Wagtail theme switch Mar 10, 2021
@allcaps allcaps mentioned this issue Mar 11, 2021
Closed
@tbrlpld tbrlpld moved this from In Progress to Code Review in Wagtail theme switch Mar 24, 2021
@tbrlpld tbrlpld mentioned this issue Mar 24, 2021
Merged
@tbrlpld tbrlpld linked a pull request Mar 24, 2021 that will close this issue
Chore 5: Cleanup layout #52
Merged
Wagtail theme switch automation moved this from Code Review to Closed Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbrlpld tbrlpld

Labels
None yet
Projects
No open projects
Wagtail theme switch
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore 5: Cleanup layout wagtail/sphinx-wagtail-theme
1 participant
@tbrlpld