Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use font and color of Wagtail brand #194

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Use font and color of Wagtail brand #194

merged 1 commit into from
Aug 18, 2022

Conversation

vsalvino
Copy link
Contributor

@vsalvino vsalvino commented Aug 17, 2022

Related: #172

This change aligns with system font and purple color changes in Wagtail 3.0:

  • Replace Source Sans with system font
  • Update purple color to match Wagtail (teal already matches).
  • Remove outdated screenshot. Replace with a description of the theme.

Variables copied from: https://github.com/wagtail/wagtail/blob/c111deef03c02c24941e06d44274a6ddf83556e4/client/src/tokens/typography.js

For consideration: Wagtail does provide a color palette of sorts... should our warning/info/etc. colors (mainly used in admonitions) also be updated to match? It is a minor and less visible detail which can probably warrant a separate pull request. I remember @Scotchester and I making effort with the current colors to meet WCAG contrast standards. See: https://docs.wagtail.org/en/latest/advanced_topics/customisation/admin_templates.html#custom-user-interface-colours

@tbrlpld
Copy link
Collaborator

tbrlpld commented Aug 18, 2022

I like this. I was playing with the idea to adopt as much of the Wagtail style guide as possible in the docs.

Unfortunately I have not gotten around to it yet. So, thanks @vsalvino for starting this!

Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to test at the moment, but the changes look good to me.

@vsalvino vsalvino mentioned this pull request Aug 18, 2022
@lb-
Copy link
Member

lb- commented Aug 18, 2022

Works great locally - thanks!

@lb- lb- merged commit cb2c510 into wagtail:main Aug 18, 2022
@lb-
Copy link
Member

lb- commented Aug 18, 2022

@vsalvino please can you raise a new issue for the review of the colours used - as noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants