Enforce order for mixin

[PaarthAgarwal]

I have enforced mixins as first in declarations. Fixes #14

[PaarthAgarwal]

I really need to learn how to use prettier😅

[lb-]

@PaarthAgarwal what editor do you use? happy to help you get your prettier set up.

As for this PR - can you please add a 'passing' example to the valid.scss https://github.com/wagtail/stylelint-config-wagtail/blob/main/__tests__/scss-valid.scss

and a failing example to the invalid scss https://github.com/wagtail/stylelint-config-wagtail/blob/main/__tests__/scss-invalid.scss

We are not currently too strict on unit tests in this repo but in this case it is an easy thing to add and also ensures there is a visual reference in the PR of what we are blocking/allowing.

[PaarthAgarwal]

@PaarthAgarwal what editor do you use? happy to help you get your prettier set up.

I appreciate your help. Currently I am using VS Code

As for this PR - can you please add a 'passing' example to the valid.scss https://github.com/wagtail/stylelint-config-wagtail/blob/main/__tests__/scss-valid.scss

and a failing example to the invalid scss https://github.com/wagtail/stylelint-config-wagtail/blob/main/__tests__/scss-invalid.scss

We are not currently too strict on unit tests in this repo but in this case it is an easy thing to add and also ensures there is a visual reference in the PR of what we are blocking/allowing.

Sure I'll add them right now

[PaarthAgarwal]

@PaarthAgarwal what editor do you use? happy to help you get your prettier set up.

As for this PR - can you please add a 'passing' example to the valid.scss https://github.com/wagtail/stylelint-config-wagtail/blob/main/__tests__/scss-valid.scss

Since we just enforced order of mixins I have moved @mixin to top in valid.css.

and a failing example to the invalid scss https://github.com/wagtail/stylelint-config-wagtail/blob/main/__tests__/scss-invalid.scss

Here @mixin was already not at the top so I feel this should be valid enough for the invalid.css to be invalid (or invalid enough for the invalid.css to be valid)

We are not currently too strict on unit tests in this repo but in this case it is an easy thing to add and also ensures there is a visual reference in the PR of what we are blocking/allowing.

Let me know if I should add separate code for them or this approach will work.

[PaarthAgarwal]

Linting issues are fixed but some errors are coming because of valid.css. Tried a few fixes but stuck.
Need help

[lb-]

OK this was a bit tricky, the issue was that when the tests fail they fail inside a promise, the simplest way around this when working locally is via logging.

Once logging was added it looks like the usage of unspecified was incorrect, I have instead changed this to 'declarations' as this seems to cover the use case fine.

Finally, there was some confusion I think the requirement was actually for the usage of mixins (via include) not the declaration of mixins (via @mixin).

I have pushed to your branch and will merge in shortly.

Thanks for this @PaarthAgarwal