Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wagtail admin hosted at a different prefix #71

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

rrebase
Copy link
Contributor

@rrebase rrebase commented Feb 27, 2020

Resolve #51 to support wagtail admin hosted at a different prefix.

Instead of using the hardcoded value it resolves from wagtailadmin_home

@rrebase rrebase changed the title Dynamic admin url Add support for wagtail admin hosted at a different prefix Feb 27, 2020
@rrebase
Copy link
Contributor Author

rrebase commented Feb 27, 2020

CI probably needs to run again. It passed, but failed to update Github status. https://www.githubstatus.com/ has reports of errors

@harrislapiroff
Copy link
Collaborator

Stunning work! Going to try to give this a final review next week.

@Toreno96
Copy link

@harrislapiroff Is it going to be reviewed soon? 🤔

Base automatically changed from master to main March 17, 2021 20:45
@andruten
Copy link

I'm also interested in this feature!

@harrislapiroff
Copy link
Collaborator

Thanks for the poke @andruten—I'll add this to our queue.

Copy link
Collaborator

@chigby chigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good to me. I tried it out on a local wagtail install with a different admin URL and it worked perfectly, assuming I also configured the autocomplete URLs to match. Well done!

@chigby chigby merged commit 4dc2a30 into wagtail:main Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support wagtail admin hosted at a different prefix
5 participants