Live receivers #11
Merged
Live receivers #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdyson
requested changes
Jun 3, 2021
Stormheg
reviewed
Jun 3, 2021
There was a problem hiding this comment.
This looks good @Tijani-Dia 🚀
I've followed the tutorial you wrote but Slack doesn't seem to be sending events to my ngrok tunnel. Likely to be a mistake on my end 😅 Left some comments on the tutorial.
The code looks good as far as I'm able to tell. Was not able to test it yet because I couldn't get Slack working for reasons mentioned above.
added 11 commits
June 6, 2021 23:53
Rewrote get_live_post_index Squash me
Tijani-Dia
force-pushed
the
live-receivers
branch
from
59876ca
to
4fd5d8a
Compare
Co-authored-by: Tom Dyson <tom@torchbox.com>
Co-authored-by: Tom Dyson <tom@torchbox.com>
Co-authored-by: Tom Dyson <tom@torchbox.com>
Co-authored-by: Tom Dyson <tom@torchbox.com>
Co-authored-by: Tom Dyson <tom@torchbox.com>
Co-authored-by: Tom Dyson <tom@torchbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to clean the Receiver classes following some of @lucasmoeskops suggestions and made a more structured PR(I really tried but the latest commits from 'Typo fix tutorial' aren't very relevant). Each commit addresses one 'topic'.
Processing images still fails!
An initial getting started tutorial is available on
docs/getting-started/tutorial.md.