Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set content-type to 'plain/text' on Slack URL verification #140

Merged
merged 3 commits into from Mar 21, 2022

Conversation

Tijani-Dia
Copy link
Collaborator

This PR sets the content type of the URL verification response to 'plain/text' instead of the default ('text/html') to avoid errors as described on #139.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022

Codecov Report

Merging #140 (2342009) into main (dd769be) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #140   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1091      1091           
  Branches       103       149   +46     
=========================================
  Hits          1091      1091           
Impacted Files Coverage Δ
src/wagtail_live/receivers/slack/receivers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd769be...2342009. Read the comment docs.

@Tijani-Dia Tijani-Dia linked an issue Mar 21, 2022 that may be closed by this pull request
@allcaps allcaps merged commit f359724 into main Mar 21, 2022
@Tijani-Dia Tijani-Dia deleted the fix/slack-verification branch March 21, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack URL verification fails
3 participants