Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wagtail Live Interface Receiver #43

Merged
merged 6 commits into from Jun 23, 2021
Merged

Wagtail Live Interface Receiver #43

merged 6 commits into from Jun 23, 2021

Conversation

Tijani-Dia
Copy link
Collaborator

I added a receiver class for Wagtail Live Interface.
It's a concrete subclass of BaseMessageReceiver so we can test the add_message, change_message and delete_message methods.

allcaps
allcaps approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@allcaps allcaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out and LGTM. Nitpick are version pinnings to those packages.

tox.ini Outdated Show resolved Hide resolved
@allcaps allcaps merged commit 66490c3 into main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allcaps allcaps allcaps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tijani-Dia @allcaps