Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full path to images in PieSocket docs #98

Merged
merged 3 commits into from Aug 13, 2021
Merged

Add full path to images in PieSocket docs #98

merged 3 commits into from Aug 13, 2021

Conversation

Tijani-Dia
Copy link
Collaborator

No description provided.

@Stormheg
Copy link
Member

This is a known issue with mkdocs: mkdocs/mkdocs#1757

@codecov-commenter
Copy link

Codecov Report

Merging #98 (8ca6a71) into main (73b9ca1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          30       30           
  Lines         927      927           
  Branches       87       87           
=======================================
  Hits          911      911           
  Misses         10       10           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b9ca1...8ca6a71. Read the comment docs.

@Stormheg
Copy link
Member

The issue over at mkdocs suggests setting site_url and using relative paths to images. I've added two commits to that effect.

@Stormheg Stormheg merged commit 2d75e7b into main Aug 13, 2021
@Tijani-Dia Tijani-Dia deleted the piesocket branch August 13, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants